Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace validate_has_extension with ensure_has_extension #1248

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Replace validate_has_extension with ensure_has_extension #1248

merged 3 commits into from
Sep 29, 2023

Conversation

jamesfisher-geo
Copy link
Collaborator

Related Issue(s):

Description:
Deprecated ExtensionManagementMixin.validate_has_extension and replaced with ExtensionManagementMixin.ensure_has_extension. Calling ExtensionManagementMixin.validate_has_extension will raise a DeprecationWarning and call ExtensionManagementMixin.ensure_has_extension

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pystac/extensions/datacube.py 80.06% <100.00%> (ø)
pystac/extensions/eo.py 93.17% <100.00%> (ø)
pystac/extensions/grid.py 96.22% <100.00%> (ø)
pystac/extensions/item_assets.py 95.37% <100.00%> (ø)
pystac/extensions/label.py 93.31% <100.00%> (ø)
pystac/extensions/mgrs.py 98.70% <100.00%> (ø)
pystac/extensions/pointcloud.py 97.81% <100.00%> (ø)
pystac/extensions/projection.py 97.08% <100.00%> (ø)
pystac/extensions/raster.py 90.22% <100.00%> (ø)
pystac/extensions/sar.py 98.56% <100.00%> (ø)
... and 10 more

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@gadomski gadomski added this pull request to the merge queue Sep 29, 2023
Merged via the queue into stac-utils:main with commit 846c30e Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants