Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups #1253

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Fixups #1253

merged 2 commits into from
Oct 3, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 3, 2023

Related Issue(s):

Description:

Spelling fixes to make CI happy, and tell codecov/patch to be nicer.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell October 3, 2023 17:09
@gadomski gadomski self-assigned this Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@gadomski gadomski added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit fd1b49a Oct 3, 2023
@gadomski gadomski deleted the fixups branch October 3, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to relax the codecov patch check even more
2 participants
@gadomski @jsignell