Add parquet and zarr media types #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
requested changes
Nov 13, 2023
pystac/media_type.py
Outdated
| @@ -15,9 +15,11 @@ class MediaType(StringEnum): | |||
| JPEG = "image/jpeg" | |||
| JPEG2000 = "image/jp2" | |||
| JSON = "application/json" | |||
| PARQUET = "application/x-parquet" | |||
There was a problem hiding this comment.
Some quick searching turned up https://lists.apache.org/thread/lrfsjhzoq20o95z5zn9zyrb8rdolqzz7 -- so eventually this may change to a vnd.* type. Can you throw in a link to the reference for the x-parquet so we know where that came from?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
=======================================
Coverage 91.10% 91.11%
=======================================
Files 51 51
Lines 6984 6986 +2
Branches 999 999
=======================================
+ Hits 6363 6365 +2
Misses 444 444
Partials 177 177 ☔ View full report in Codecov by Sentry. |
gadomski
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In working on xpystac I thought it might be useful to add zarr and parquet to the media type enum
PR Checklist:
pre-commithooks pass locallyscripts/test)Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.