Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fall back to epsg in crs_string, too #1510

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix: fall back to epsg in crs_string, too #1510

merged 2 commits into from
Jan 27, 2025

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jan 27, 2025

Description:

Hopefully this, with #1509, will fix our backwards-compatability 🤞🏼 . We didn't catch this previously because our other proj v1.1 item had a proj:wkt set.

PR Checklist:

  • Pre-commit hooks and tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski self-assigned this Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (21a0bbb) to head (5ebee47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1510   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          54       54           
  Lines        7520     7522    +2     
  Branches      910      911    +1     
=======================================
+ Hits         6879     6881    +2     
  Misses        457      457           
  Partials      184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 14a4626 Jan 27, 2025
23 checks passed
@gadomski gadomski deleted the crs-with-epsg branch January 27, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants