-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial on adding new extensions #724
Update tutorial on adding new extensions #724
Conversation
Codecov Report
@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 77 77
Lines 11285 11285
Branches 1347 1347
=======================================
Hits 10646 10646
Misses 459 459
Partials 180 180 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only gave it a light read.
796717a
to
3495885
Compare
@lossyrob @matthewhanson I'll plan on merging this by the end of today if there isn't any additional feedback. |
Related Issue(s):
Description:
Updates the "Adding New and Custom Extensions" tutorial to be up-to-date with the new extensions API. The tutorial covers implementation of a
PropertiesExtension
sub-class that operates on Items, but does not cover summaries (a separate tutorial on creating summaries in general may be in order anyway).Also updates the order of the TOC in the
tutorials*
pages to match the order of the tutorials in the index page.PR Checklist:
pre-commit run --all-files
)scripts/test
)