Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental Python 3.11 support #731

Merged
merged 6 commits into from
Jan 31, 2022

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jan 26, 2022

Related Issue(s):

None

Description:

Adds Python 3.11.0-alpha.4 to our CI test matrix and adds a note on experimental support to the README.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

Codecov Report

Merging #731 (cb9217a) into main (d659185) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files          77       77           
  Lines       11285    11285           
  Branches     1347     1347           
=======================================
  Hits        10646    10646           
  Misses        459      459           
  Partials      180      180           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d659185...cb9217a. Read the comment docs.

@duckontheweb duckontheweb added this to the 1.4.0 milestone Jan 26, 2022
@duckontheweb
Copy link
Contributor Author

This also removes the Rust toolchain from the Python 3.10 CI build since orjson is consistently providing wheels for that version now.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only question: should the 3.11 CI build be marked "ok to fail"?

@duckontheweb
Copy link
Contributor Author

LGTM, only question: should the 3.11 CI build be marked "ok to fail"?

Yes, good catch!

@duckontheweb
Copy link
Contributor Author

LGTM, only question: should the 3.11 CI build be marked "ok to fail"?

Yes, good catch!

I updated the CI to specifically call out experimental Python versions using an include statement and use a conditional continue-on-error statement to allow the workflow to succeed if these fail. This is more in line with the GitHub Actions example and I think it's more clear that the experimental versions are just that.

@duckontheweb duckontheweb merged commit 206b76f into stac-utils:main Jan 31, 2022
@duckontheweb duckontheweb deleted the add/python-3.11 branch January 31, 2022 15:18
@duckontheweb duckontheweb mentioned this pull request Jan 31, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants