Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "how to create STAC catalogs" tutorial #775

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Mar 29, 2022

Related Issue(s):

Description: Fixes the how-to-create-stac-catalogs tutorial to use the new extension syntax. Also includes:

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #775 (3f88cde) into main (3209bf8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          79       79           
  Lines       11647    11647           
  Branches     1372     1372           
=======================================
  Hits        11013    11013           
  Misses        455      455           
  Partials      179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3209bf8...3f88cde. Read the comment docs.

@gadomski gadomski force-pushed the issues/771-fix-tutorial branch from ee7beed to c836cf7 Compare March 29, 2022 13:25
@gadomski gadomski force-pushed the issues/771-fix-tutorial branch from c836cf7 to 801fbfe Compare March 30, 2022 14:27
Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @gadomski !

@duckontheweb duckontheweb merged commit 443828f into main Mar 30, 2022
@duckontheweb duckontheweb deleted the issues/771-fix-tutorial branch March 30, 2022 15:20
@duckontheweb duckontheweb added this to the 1.5.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in pystac/docs/tutorials/how-to-create-stac-catalogs.ipynb
3 participants