Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link #915

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix broken link #915

merged 1 commit into from
Nov 10, 2022

Conversation

dlebauer
Copy link
Contributor

@dlebauer dlebauer commented Nov 9, 2022

seems like a small typo. Currently, the link is rendered and constructed incorrectly.

Related Issue(s): #

Description:

image

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and fix!

seems like a small typo. Currently, the link is rendered and constructed incorrectly.
@codecov-commenter
Copy link

Codecov Report

Base: 94.31% // Head: 94.31% // No change to project coverage 👍

Coverage data is based on head (80b96c8) compared to base (fb0e23f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files          80       80           
  Lines       11923    11923           
  Branches     1130     1130           
=======================================
  Hits        11245    11245           
  Misses        496      496           
  Partials      182      182           
Impacted Files Coverage Δ
pystac/extensions/table.py 69.93% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski
Copy link
Member

Force-pusehed to get CI to run, I couldn't see the "Run actions" button like I usually can.

@gadomski gadomski merged commit f26abd8 into stac-utils:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants