Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass href to item constructor in from_dict #984

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Feb 14, 2023

Related Issue(s):

Description:

Turns out the fix was simple -- href wasn't getting passed from Item.from_dict to the Item constructor.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added this to the 1.7 milestone Feb 14, 2023
@gadomski gadomski requested a review from pjhartzell February 14, 2023 15:59
@gadomski gadomski self-assigned this Feb 14, 2023
@gadomski gadomski changed the title fix: pass href to item constructor in from_dict Pass href to item constructor in from_dict Feb 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Base: 90.28% // Head: 90.32% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (c9567a8) compared to base (de52adb).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
+ Coverage   90.28%   90.32%   +0.03%     
==========================================
  Files          47       47              
  Lines        6137     6137              
  Branches      915      915              
==========================================
+ Hits         5541     5543       +2     
+ Misses        414      413       -1     
+ Partials      182      181       -1     
Impacted Files Coverage Δ
pystac/item.py 92.85% <ø> (+0.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski enabled auto-merge February 14, 2023 19:11
@gadomski gadomski added this pull request to the merge queue Feb 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 14, 2023
@gadomski gadomski added this pull request to the merge queue Feb 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 14, 2023
@gadomski gadomski added this pull request to the merge queue Feb 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 14, 2023
@gadomski gadomski force-pushed the issues/801-normalize-hrefs branch from c9567a8 to bc87db1 Compare February 14, 2023 19:18
@gadomski gadomski enabled auto-merge February 14, 2023 19:18
@gadomski gadomski added this pull request to the merge queue Feb 14, 2023
Merged via the queue into main with commit 1cc86cd Feb 14, 2023
@gadomski gadomski deleted the issues/801-normalize-hrefs branch February 14, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

normalise_hrefs causing unwanted Item asset href changes.
3 participants