Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Though I initially thought I could do this without urllib3, as I was implementing I decided it was silly to just copy the functionality from urllib3, since it's so commonly on systems w/ PySTAC. So I added it as an
extras_require
. The urllib3 typing story is a bit of a mess, so I had to use a couple of# type: ignore
s. Testing retries is more trouble than its worth IMO, so I only included smoke tests for reading with the new class.Background:
requests uses urllib3, so I consider urllib3 a pretty no-brainer library to optionally depend on -- it's everywhere.
Sidecar:
pystac-vcr
as a test dependency, with an eye towards Avoid network calls in tests suite #949requirements-test.txt
because its arbitrary layout was getting to me ... now it's just a sorted listPR Checklist:
pre-commit run --all-files
)scripts/test
)