POST a feature collection to the items route #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs a changelog entry. |
philvarner
reviewed
Mar 25, 2022
| bulk_client = BulkTransactionsClient(session=self.session) | ||
| return_msg = bulk_client.bulk_item_insert(items=model["features"]) | ||
|
|
||
| return return_msg |
There was a problem hiding this comment.
this should return None per the signature.
There was a problem hiding this comment.
I'm about to open another PR that will actually change that signature to be Optional[stac_types.Item], to advertise that None is a valid response
moradology
reviewed
Apr 18, 2022
| @@ -35,11 +35,19 @@ class TransactionsClient(BaseTransactionsClient): | |||
| ) | |||
|
|
|||
| def create_item( | |||
| self, item: stac_types.Item, **kwargs | |||
| self, model: Union[stac_types.Item, stac_types.ItemCollection], **kwargs | |||
There was a problem hiding this comment.
I've updated this to reflect the fact that the model is either Item or ItemCollection
moradology
approved these changes
Apr 18, 2022
This was referenced Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
POST collections/{collectionId}/itemsshould accept an ItemCollection #362Description:
Allow for the items route to accept a feature collection as well as a single item.
PR Checklist:
pre-commit run --all-files)make test)make docs)