Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace values above limit with limit value. #526

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Replace values above limit with limit value. #526

merged 3 commits into from
Feb 9, 2023
+52 −5

Conversation

eseglem
Copy link
Contributor

@eseglem eseglem commented Feb 9, 2023 •
edited
Loading

Related Issue(s):

Description:

Added a subclass of ConstrainedInt which replaces values above 10,000 with 10,000 to conform with the spec.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@gadomski gadomski self-requested a review February 9, 2023 12:58
@gadomski gadomski added this to the 2.4.4 milestone Feb 9, 2023
gadomski
gadomski approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@gadomski gadomski merged commit edc97e9 into stac-utils:master Feb 9, 2023
@gadomski gadomski linked an issue Feb 9, 2023 that may be closed by this pull request
limit value above the maximum advertised (or allowed) should return that max limit rather than 400 #496
Closed
@eseglem eseglem deleted the bugfix/limit-limit-value branch February 17, 2023 05:34
@pedro-cf pedro-cf mentioned this pull request May 6, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.4
Development

Successfully merging this pull request may close these issues.

limit value above the maximum advertised (or allowed) should return that max limit rather than 400
2 participants
@eseglem @gadomski