Fix STAC API Query Extension operator names from ne->neq, le->lte, and ge->gte #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 9, 2023 14:43
…d ge->gte, fix operations mappings
…>lte, and ge->gte, fix operations mappings" This reverts commit 5df1f99.
…d ge->gte, fix operations mappings
|
I'm a bit worry about changing this right now, could we still support the |
Sure. I'm not able to work on this though, so someone else will have to do it. |
| f"`{self._value_}` is deprecated, please use `{newvalue}`", | ||
| DeprecationWarning, | ||
| stacklevel=3, | ||
| ) |
There was a problem hiding this comment.
It's quite hard to add deprecation warning on Enums 😓 so for now I think adding a warning on the operator method is a least we can do
vincentsarago
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were incorrect wrt the spec: https://github.com/stac-api-extensions/query/blob/main/openapi.yaml