Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run integration tests in CI #163

Merged
merged 13 commits into from
Feb 21, 2022
Merged

Run integration tests in CI #163

merged 13 commits into from
Feb 21, 2022

Conversation

marchuffnagle
Copy link
Contributor

@marchuffnagle marchuffnagle commented Feb 20, 2022 •
edited
Loading

Related Issue(s):

Proposed Changes:

  1. Add an Elasticsearch Docker container to CI
  2. Update CI tests to use http requests rather than calling the API function code directly. This will help keep our integration tests black-boxed.
  3. Run integration tests in CI

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
    • No changelog entry required, these are development-only changes
  • Update README

@marchuffnagle marchuffnagle added the WIP Work In Progress label Feb 20, 2022
@marchuffnagle marchuffnagle changed the title WIP Run integration tests in CI Run integration tests in CI Feb 20, 2022
@marchuffnagle marchuffnagle requested review from philvarner and matthewhanson and removed request for philvarner February 20, 2022 04:23
@marchuffnagle marchuffnagle removed the WIP Work In Progress label Feb 20, 2022
This was referenced Feb 20, 2022
Closed
Closed
philvarner
philvarner reviewed Feb 21, 2022
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@marchuffnagle marchuffnagle merged commit 51d32b7 into main Feb 21, 2022
@marchuffnagle marchuffnagle deleted the int-tests-in-ci branch February 21, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philvarner philvarner philvarner approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration tests not being run in CI local integration test should execute from one command
2 participants
@marchuffnagle @philvarner