support open-ended datetime intervals, fix camelcase violations

[philvarner]

Related Issue(s): #137

Proposed Changes:

1. support open-ended datetime intervals (e.g., ../{datetime}, /{datetime}, {datetime}/.., or {datetime}/
2. fix a few camelcase violations

PR Checklist:

• I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

[matthewhanson]

LGTM other than the failing test that is still using the old snake case function create_indices

[marchuffnagle]

Rather than negating this and then having an else clause, it would be a bit easier to read if it said if (datetime.includes('/')) { and then the conditional orders were swapped.

[marchuffnagle]

Suggested change

	const mapping = (index === 'collections' ? collectionsMapping : itemsMapping)
	const mapping = index === 'collections' ? collectionsMapping : itemsMapping

[philvarner]

Looks like this change was already made?

[marchuffnagle]

It's more verbose, but consider breaking this function apart into something like this. I think it makes it easier to understand what's going on.

/**
 * @param {string} datetime
 * @returns {unknown}
 */
const buildDatetimeRange = (datetime) => {
  const [start, end, ...rest] = datetime.split('/')

  if (rest.length > 0) {
    return new Error('datetime value is invalid, contains more than one forward slash')
  }

  if (!start && !end) {
    return new Error(
      'datetime value is invalid, at least one end of the interval must be closed'
    )
  }

  if (start === '..' && end === '..') {
    return new Error(
      'datetime value is invalid, at least one end of the interval must be closed'
    )
  }

  let range

  if (start && end) range = { gte: start, lte: end }
  else if (start) range = { gte: start }
  else range = { lte: end }

  return {
    range: {
      'properties.datetime': range
    }
  }
}

/**
 * @param {string} datetime
 * @returns {unknown}
 */
const buildDatetimeTerm = (datetime) => ({
  term: {
    'properties.datetime': datetime
  }
})

/**
 * @param {string} datetime
 * @returns {boolean}
 */
const isExactDatetime = (datetime) => !datetime.includes('/')

/**
 * @param {Object} params
 * @param {string} params.datetime
 * @returns {unknown|Error|undefined}
 */
const buildDatetimeQuery = ({ datetime }) => {
  if (!datetime) return undefined

  return isExactDatetime(datetime)
    ? buildDatetimeTerm(datetime)
    : buildDatetimeRange(datetime)
}

[philvarner]

I chose not to do too much work on this right now because we need to significantly improve the datetime validation #175

[marchuffnagle]

Closes #137