Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm build problem #188

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Fix npm build problem #188

merged 3 commits into from
Feb 23, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): n/a

Proposed Changes:

  1. fix incorrect location of api.yaml in webpack config
  2. run build for all PRs

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

**Related Issue(s):** #
**Related Issue(s):**

- #
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes it so it uses rich formatting like

@@ -33,7 +33,7 @@ module.exports = {
plugins: [
new CopyPlugin({
patterns: [{
from: '../../lib/api.yaml',
from: '../../lambdas/api/api.yaml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from: '../../lambdas/api/api.yaml',
from: 'api.yaml',

@philvarner philvarner merged commit 7989526 into main Feb 23, 2022
@philvarner philvarner deleted the fix-npm-build-problem branch February 23, 2022 17:01
philvarner pushed a commit that referenced this pull request Feb 28, 2022
* PR template: put related issues in list for rich formatting

* fix path of api.yaml in webpack, add npm build to GH Action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants