Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix various issues with link relations #328

Merged
merged 3 commits into from
Dec 15, 2022
Merged

fix various issues with link relations #328

merged 3 commits into from
Dec 15, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

Proposed Changes:

Fix various issues with link relations, including:

  1. missing type fields
  2. unnecessary trailing / on root endpoint
  3. add missing self, root, and parent to collections endpoint

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner merged commit 1cbb939 into main Dec 15, 2022
@philvarner philvarner deleted the pv/fix-issues-with-links branch December 15, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhanson matthewhanson matthewhanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philvarner @matthewhanson