-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add point endpoint #150
Conversation
"values": [ | ||
(src, pts.data.tolist(), pts.band_names) for src, pts in values | ||
], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now equivalent to https://github.com/developmentseed/titiler/blob/main/src/titiler/mosaic/titiler/mosaic/factory.py#L672-L677 and remove the need of custom model
|
||
out: Dict[str, Any] = {} | ||
for val, asset in filter_tasks(tasks, allowed_exceptions=allowed_exceptions): | ||
item_id = f"{asset['collection']}/{asset['id']}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collection and id are mandatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentsarago that looks like a cleaner version of what I attempted in #146 - thank you for fixing it up!
@hrodmn I'm having second though on the endpoint path I know we already have would you be ok if we change this to |
That's fine with me. When I started working on it I went with |
continues #146
The mai change is that I'm introducing
multi_points_pgstac
which replace rio-tiler'smulti_values
method (because we use item dict instead of url, so it's not hashable as dict key).In
multi_points_pgstac
I'm constructing an Item ID using the id and collection which we says aremandatory
(this is not asserted but should)@hrodmn could you have a look and tell me your tough