[TO BE DISCUSSED] add mosaic listing endpoint #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Mar 1, 2022
| # filter to only return `metadata->type == 'mosaic'` | ||
| mosaic_filter = sql.SQL("metadata::json->>{key} = {value}").format( | ||
| key=sql.Literal("type"), value=sql.Literal("mosaic") | ||
| ) |
There was a problem hiding this comment.
we only want the search with metadata.type = "mosaic"
vincentsarago
commented
Mar 1, 2022
| rel="self", | ||
| href=self.url_for(request, "list_search") + qs, | ||
| ), | ||
| # TODO: next |
This was referenced Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work done in #44 and adds a
/listendpoint to list the mosaics stored in the pgstac db. By default it will only return thesearchwithmetadata.type == "mosaic"(tag added when registered the search via the/registerendpoint.I know @bitner raised some performance issue that could appear when there are a lot
searchin the search table 🤷♂️IMO the
/listendpoint could be valuable for debugging purpose or for uses who have not a lot of entries in thesearchtable. I think the endpoint should not be added by default, and I'm also happy to only add this code in the documentation.cc @sharkinsspatial