Support providing postgres settings via argument #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alukach
commented
Apr 30, 2022
Co-authored-by: Anthony Lukach <[email protected]>
vincentsarago
approved these changes
May 2, 2022
There was a problem hiding this comment.
🙏 thanks @alukach
Would be great if you could add a line in the changelog 🙏
Just added on comment but if you feel it isn't necessary you can go ahead and merge.
alukach
commented
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this codebase expects that the postgres configuration be available via environment variables. However, there are situations in which a user might not have these configurations available in the runtime environment. For example, a user might want their application to be responsive to DB credential changes without redeployment so they fetch credentials at Lambda startup from AWS Secrets Manager.
This PR reworks the
connect_to_db()to take thePostgresSettingsinstance as an argument (ie Inversion of Control). This makes it easier for systems that depend on extending this codebase to customize how they generate settings./cc @anayeaye