Remove LRU cache #54
Merged
Remove LRU cache #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the LRU cache does not offer any benefit, as the settings are on initialized once at app startup: https://github.com/stac-utils/titiler-pgstac/blob/780f4f8815f9349f72bb7805fad1306bb4412291/titiler/pgstac/main.py#L31 https://github.com/stac-utils/titiler-pgstac/blob/780f4f8815f9349f72bb7805fad1306bb4412291/titiler/pgstac/db.py#L12-L17 https://github.com/stac-utils/titiler-pgstac/blob/780f4f8815f9349f72bb7805fad1306bb4412291/titiler/pgstac/dependencies.py#L20 They additionally don't allow settings to be provided manually by keyword arguments. If it is deemed preferable to have the LRU present, an alternative solution would be to alter the cached function to pass through kwargs to the settings class.
alukach
added a commit
to alukach/titiler-pgstac
that referenced
this pull request
May 5, 2022
To enable users to manually specify settings (e.g. pass them in via keyword arguments), cached settings should pass along keyword arguments. This is an alternative solution to stac-utils#54.
Closed
vincentsarago
approved these changes
May 5, 2022
|
@alukach could you please update the changelog 🙏 |
vincentsarago
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the LRU cache does not offer any benefit, as the settings are initialized just once at app startup:
titiler-pgstac/titiler/pgstac/main.py
Line 31 in 780f4f8
titiler-pgstac/titiler/pgstac/db.py
Lines 12 to 17 in 780f4f8
titiler-pgstac/titiler/pgstac/dependencies.py
Line 20 in 780f4f8
They additionally don't allow settings to be provided manually by keyword arguments. If it is deemed preferable to have the LRU present, an alternative solution would be to alter the cached function to pass through kwargs to the settings class.