Bug fixes #115

olivier-stasse · 2023-10-24T13:10:03Z

This PR fixes a certain number of fixes:

Missing include(cmake/python.cmake)
sprintf in interpreter.cpp which is deprecated.
Ambiguous long int and unsigned long int in convert-dg-to-py
Removed unused member locals_ in Interpreter class.
Fix a cast (warning)

Include python to have python-helpers for python_install_on_site.

for more information, see https://pre-commit.ci

nim65s · 2023-10-24T13:25:24Z

CMakeLists.txt

@@ -21,6 +21,7 @@ set(DOXYGEN_USE_MATHJAX YES)
 # JRL-cmakemodule setup
 include(cmake/base.cmake)
 include(cmake/boost.cmake)
+include(cmake/python.cmake)


We shouldn't include this file. eigenpy package its version, and this should be the good one to use

Not doing it ends up with:

--- stderr: dynamic-graph-python CMake Error at src/CMakeLists.txt:9 (python_install_on_site): Unknown CMake command "python_install_on_site".

with eigenpy-3.1.0

Can you try again with 3.1.1 ? I think 3.1.0 was broken on this topic

I will remove this line and will use locally. eigenpy is still in 3.1.0 on conda (the environment I am currently testing), and I would like to avoid recompiling pinocchio.

src/dynamic_graph/convert-dg-to-py.cc

florent-lamiraux · 2023-10-24T14:00:10Z

cmake

This update removes files compile.py that seems necessary.

Do you have an error message about this ?

Yes even after removing the build directory.

[ 37%] Linking CXX shared module dynamic_graph/tracer/wrap.so cd /home/florent/devel/hpp/src/dynamic-graph-python/build-rel/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/tracer-wrap.dir/link.txt --verbose=1 /usr/lib/ccache/g++ -fPIC -pedantic -Wno-long-long -Wall -Wextra -Wcast-align -Wcast-qual -Wformat -Wwrite-strings -Wconversion -O3 -DNDEBUG -shared -o dynamic_graph/tracer/wrap.so CMakeFiles/tracer-wrap.dir/dynamic_graph/tracer/wrap.cc.o -L/home/florent/devel/hpp/src/dynamic-graph-python/src/lib/dynamic-graph-plugins -Wl,-rpath,"lib/dynamic-graph-plugins:\$ORIGIN/../../../../../lib/dynamic-graph-plugins:/home/florent/devel/hpp/src/dynamic-graph-python/src/lib/dynamic-graph-plugins:/home/florent/devel/hpp/install/lib/dynamic-graph-plugins:/home/florent/devel/hpp/src/dynamic-graph-python/build-rel:/home/florent/devel/hpp/install/lib:" -Wl,--no-as-needed /home/florent/devel/hpp/install/lib/dynamic-graph-plugins/libtracer.so /usr/lib/x86_64-linux-gnu/libboost_python38.so ../libdynamic-graph-python.so /home/florent/devel/hpp/install/lib/libdynamic-graph.so /usr/lib/x86_64-linux-gnu/libboost_serialization.so.1.71.0 /usr/lib/x86_64-linux-gnu/libboost_system.so.1.71.0 /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.71.0 /usr/lib/x86_64-linux-gnu/libboost_atomic.so.1.71.0 -lpthread -ldl -lpthread /usr/lib/x86_64-linux-gnu/libboost_python38.so /usr/lib/x86_64-linux-gnu/libpython3.8.so make[3]: Leaving directory '/home/florent/devel/hpp/src/dynamic-graph-python/build-rel' [ 37%] Built target tracer-wrap make -f src/CMakeFiles/compile_pyc__home_florent_devel_hpp_src_dynamic-graph-python_src.dir/build.make src/CMakeFiles/compile_pyc__home_florent_devel_hpp_src_dynamic-graph-python_src.dir/depend make[3]: Entering directory '/home/florent/devel/hpp/src/dynamic-graph-python/build-rel' cd /home/florent/devel/hpp/src/dynamic-graph-python/build-rel && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/florent/devel/hpp/src/dynamic-graph-python /home/florent/devel/hpp/src/dynamic-graph-python/src /home/florent/devel/hpp/src/dynamic-graph-python/build-rel /home/florent/devel/hpp/src/dynamic-graph-python/build-rel/src /home/florent/devel/hpp/src/dynamic-graph-python/build-rel/src/CMakeFiles/compile_pyc__home_florent_devel_hpp_src_dynamic-graph-python_src.dir/DependInfo.cmake --color= Scanning dependencies of target compile_pyc__home_florent_devel_hpp_src_dynamic-graph-python_src make[3]: Leaving directory '/home/florent/devel/hpp/src/dynamic-graph-python/build-rel' make -f src/CMakeFiles/compile_pyc__home_florent_devel_hpp_src_dynamic-graph-python_src.dir/build.make src/CMakeFiles/compile_pyc__home_florent_devel_hpp_src_dynamic-graph-python_src.dir/build make[3]: Entering directory '/home/florent/devel/hpp/src/dynamic-graph-python/build-rel' cd /home/florent/devel/hpp/src/dynamic-graph-python/build-rel/src && /usr/bin/python3 /home/florent/devel/hpp/src/dynamic-graph-python/cmake/compile.py /home/florent/devel/hpp/src/dynamic-graph-python/src /home/florent/devel/hpp/src/dynamic-graph-python/build-rel/src dynamic_graph/__init__.py /usr/bin/python3: can't open file '/home/florent/devel/hpp/src/dynamic-graph-python/cmake/compile.py': [Errno 2] No such file or directory make[3]: *** [src/CMakeFiles/compile_pyc__home_florent_devel_hpp_src_dynamic-graph-python_src.dir/build.make:60: compile_pyc__home_florent_devel_hpp_src_dynamic-graph-python_src] Error 2 make[3]: Leaving directory '/home/florent/devel/hpp/src/dynamic-graph-python/build-rel' make[2]: *** [CMakeFiles/Makefile2:1520: src/CMakeFiles/compile_pyc__home_florent_devel_hpp_src_dynamic-graph-python_src.dir/all] Error 2 make[2]: Leaving directory '/home/florent/devel/hpp/src/dynamic-graph-python/build-rel' make[1]: *** [Makefile:144: all] Error 2 make[1]: Leaving directory '/home/florent/devel/hpp/src/dynamic-graph-python/build-rel' make: *** [Makefile:694: dynamic-graph-python.install_nodep] Error 2

I can't reproduce. Could you try to clean your config/build directories, and try again ?

Oh, wait, maybe this is an issue with the added include(cmake/python.cmake). Could you try to remove it and start again ?

I had an old version of eigenpy. I have updated and I am recompiling.

After recompiling and removing include(cmake/python.cmake) it now works.

nim65s

gitlab-ci did not start properly. I launched it manually, and it failed: https://gitlab.laas.fr/stack-of-tasks/dynamic-graph-python/-/jobs/216685

In file included from /root/robotpkg/wip/py-dynamic-graph-v3/work/dynamic-graph-python-4.0.11/include/dynamic-graph/python/dynamic-graph-py.hh:13,
from /root/robotpkg/wip/py-dynamic-graph-v3/work/dynamic-graph-python-4.0.11/src/dynamic_graph/entity-py.cc:13:
/root/robotpkg/wip/py-dynamic-graph-v3/work/dynamic-graph-python-4.0.11/include/dynamic-graph/python/signal-wrapper.hh:25:45: error: 'sigtime_t' was not declared in this scope; did you mean 'time_t'?
25 |   void signalRegistration(const SignalArray<sigtime_t>& signals);
|                                             ^~~~~~~~~
|                                             time_t
/root/robotpkg/wip/py-dynamic-graph-v3/work/dynamic-graph-python-4.0.11/include/dynamic-graph/python/signal-wrapper.hh:25:54: error: template argument 1 is invalid
25 |   void signalRegistration(const SignalArray<sigtime_t>& signals);
|                                                      ^

florent-lamiraux · 2023-10-24T15:10:44Z

gitlab-ci did not start properly. I launched it manually, and it failed: https://gitlab.laas.fr/stack-of-tasks/dynamic-graph-python/-/jobs/216685

This is probrably due to a wrong version of dynamic-graph.

olivier-stasse · 2023-10-25T02:59:50Z

gitlab-ci did not start properly. I launched it manually, and it failed: https://gitlab.laas.fr/stack-of-tasks/dynamic-graph-python/-/jobs/216685

This is probrably due to a wrong version of dynamic-graph.

Yes we probably need a release of dynamic-graph.

olivier-stasse · 2023-10-25T05:24:45Z

@nim65s : I finally recompiled eigenpy with 3.1.1,hpp-fcl and pinocchio from HEAD of devel and it works.
So it should be as requested.
Thanks for the feedback !

olivier-stasse and others added 7 commits October 24, 2023 14:51

[cmake] Sync

172d479

[CMakeLists.txt] Update requirement of cmake to 3.10

231ae4a

Include python to have python-helpers for python_install_on_site.

[interpreter] Remove unused member.

6e83680

[convert-dg-to-py] Remove ambiguous types.

a3c40d9

[entity-py] Fix cast.

a2af6ec

[interpreter] using sprintf is deprecated.

81e121f

[pre-commit.ci] auto fixes from pre-commit.com hooks

5f0e03c

for more information, see https://pre-commit.ci

olivier-stasse requested review from nim65s and florent-lamiraux October 24, 2023 13:24

nim65s requested changes Oct 24, 2023

View reviewed changes

florent-lamiraux approved these changes Oct 24, 2023

View reviewed changes

nim65s requested changes Oct 24, 2023

View reviewed changes

Remove include(cmake/python.cmake) and put cstdint

f683732

nim65s approved these changes Oct 25, 2023

View reviewed changes

nim65s merged commit 5330bd0 into stack-of-tasks:devel Oct 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug fixes #115

Bug fixes #115

olivier-stasse commented Oct 24, 2023

nim65s Oct 24, 2023

olivier-stasse Oct 24, 2023

olivier-stasse Oct 24, 2023

nim65s Oct 24, 2023

olivier-stasse Oct 24, 2023

florent-lamiraux Oct 24, 2023

nim65s Oct 24, 2023

florent-lamiraux Oct 24, 2023

nim65s Oct 24, 2023

nim65s Oct 24, 2023

florent-lamiraux Oct 24, 2023

florent-lamiraux Oct 24, 2023

nim65s left a comment

florent-lamiraux commented Oct 24, 2023

olivier-stasse commented Oct 25, 2023

olivier-stasse commented Oct 25, 2023

Bug fixes #115

Bug fixes #115

Conversation

olivier-stasse commented Oct 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nim65s left a comment

Choose a reason for hiding this comment

florent-lamiraux commented Oct 24, 2023

olivier-stasse commented Oct 25, 2023

olivier-stasse commented Oct 25, 2023