Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docker image #119

Merged
merged 14 commits into from
Nov 12, 2021
Merged

Use docker image #119

merged 14 commits into from
Nov 12, 2021

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Nov 4, 2021 •
edited
Loading

Description

fixes #118

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

@maltesander maltesander requested a review from a team November 4, 2021 17:50
@maltesander maltesander self-assigned this Nov 4, 2021
@maltesander maltesander marked this pull request as ready for review November 11, 2021 16:25
razvan
razvan previously approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rust/operator/src/lib.rs Outdated Show resolved Hide resolved
@maltesander maltesander requested a review from razvan November 11, 2021 17:06
razvan
razvan approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@maltesander maltesander merged commit e92c914 into main Nov 12, 2021
@maltesander maltesander deleted the use_docker_image branch November 12, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Operator to K8S Architecture
2 participants
@maltesander @razvan