Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed configurable port from code and product config. #156

Merged
merged 6 commits into from
Dec 17, 2021
Merged

Removed configurable port from code and product config. #156

merged 6 commits into from
Dec 17, 2021

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Dec 17, 2021 •
edited
Loading

Description

  • Changed version to string
  • Updated dependencies
  • Fixed comments
  • Removed port from code and product config

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

@maltesander maltesander requested a review from nightkr December 17, 2021 13:56
@maltesander maltesander self-assigned this Dec 17, 2021
@maltesander maltesander marked this pull request as ready for review December 17, 2021 13:58
nightkr
nightkr reviewed Dec 17, 2021
View reviewed changes
deploy/config-spec/properties.yaml Outdated Show resolved Hide resolved
rust/operator/src/opa_controller.rs Outdated Show resolved Hide resolved
rust/operator/src/opa_controller.rs Show resolved Hide resolved
rust/operator/src/opa_controller.rs Show resolved Hide resolved
nightkr
nightkr previously approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass

@maltesander maltesander merged commit 6c03458 into main Dec 17, 2021
@maltesander maltesander deleted the fixes branch December 17, 2021 16:45
@maltesander maltesander mentioned this pull request Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @nightkr