Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Dependencies and scraping #218

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Dependencies and scraping #218

wants to merge 7 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Feb 8, 2022 •
edited
Loading

Description

fixes #201

  • updated dependencies, operator-rs -> 0.10.0
  • fixed doc (added supported version)
  • added scraping label
  • readiness and liveness probes

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team February 8, 2022 16:35
@maltesander maltesander self-assigned this Feb 8, 2022
@maltesander maltesander marked this pull request as ready for review February 8, 2022 16:52
@maltesander maltesander requested a review from nightkr February 9, 2022 10:40
nightkr
nightkr approved these changes Feb 9, 2022
View reviewed changes
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
@maltesander maltesander requested a review from nightkr February 9, 2022 12:44
@maltesander
Copy link
Member Author

bors merge

@maltesander
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Feb 9, 2022
@maltesander
Dependencies and scraping (#218)
cca5420 
## Description

fixes #201

- updated dependencies, operator-rs -> 0.10.0
- fixed doc (added supported version)
- added scraping label
- readiness and liveness probes



Co-authored-by: Malte Sander <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 9, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Dependencies and scraping [Merged by Bors] - Dependencies and scraping Feb 9, 2022
@bors bors bot closed this Feb 9, 2022
@bors bors bot deleted the dependencies_and_scraping branch February 9, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Prometheus scraping
2 participants
@maltesander @nightkr