Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - 274 document the bundlebuilder and rego rule configmaps #350

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - 274 document the bundlebuilder and rego rule configmaps #350

wants to merge 11 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Sep 26, 2022

Fixes #274

@razvan razvan linked an issue Sep 26, 2022 that may be closed by this pull request
Document the BundleBuilder and Rego rule ConfigMaps #274
Closed
6 tasks
maltesander
maltesander requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make sure that we use Rego/rego/Rego-rules/Rego rules consistently? I think sometimes i saw it written with lower case.

docs/modules/ROOT/pages/implementation-notes.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/implementation-notes.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/implementation-notes.adoc Outdated Show resolved Hide resolved
@razvan
Copy link
Member Author

razvan commented Sep 26, 2022

Replaced "rego" with "policy" where appropriate.

@razvan
Copy link
Member Author

razvan commented Sep 26, 2022 •
edited
Loading

🟢 CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/opa-operator-it-custom/14/

@razvan razvan requested a review from maltesander September 26, 2022 13:42
maltesander
maltesander reviewed Sep 26, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One unresolved left.

@razvan razvan requested a review from maltesander September 26, 2022 14:47
maltesander
maltesander approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor thing.

docs/modules/getting_started/pages/first_steps.adoc Outdated Show resolved Hide resolved
@razvan
Copy link
Member Author

razvan commented Sep 26, 2022

bors merge

bors bot pushed a commit that referenced this pull request Sep 26, 2022
@razvan
274 document the bundlebuilder and rego rule configmaps (#350)
a894975 
Fixes #274
@bors
Copy link
Contributor

bors bot commented Sep 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title 274 document the bundlebuilder and rego rule configmaps [Merged by Bors] - 274 document the bundlebuilder and rego rule configmaps Sep 26, 2022
@bors bors bot closed this Sep 26, 2022
@bors bors bot deleted the 274-document-the-bundlebuilder-and-rego-rule-configmaps branch September 26, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the BundleBuilder and Rego rule ConfigMaps
2 participants
@razvan @maltesander