Quickcheck property tests #128
Conversation
Quickcheck quote See merge request wild_willy/hapistrano!1
Added quickcheck for trim and quoteCmd
|
Introduced one more property test for mkGenericCmd and unGenericCmd and solved conflicts. |
|
@cptrodolfox Do not forget about fixing the issue with the haddock not being able to generate the documentation for a file and another file not being totally covered by documentation |
|
@juanpaucar Fix the haddock errors. |
|
@cptrodolfox It looks like newer versions of GHC are still failing during CI |
|
There is problem with Haddock coverage and the different version of ghc. |
cptrodolfox
force-pushed
the
quickcheck
branch
from
d4d3c6f to
b2fe10d
Compare
| @@ -40,7 +40,7 @@ script: | |||
| - cabal build --enable-tests | |||
| - cabal test --enable-tests | |||
| - cabal sdist | |||
| - cabal haddock | grep "100%" | wc -l | grep "4" | |||
| - cabal haddock | grep "100%" | wc -l | grep -G "[45]" # Fixes issue with different haddock coverage with different ghc versions https://github.com/haskell/haddock/issues/123 | |||
There was a problem hiding this comment.
Sorry, I'm facing the same issue in ivanperez-keera/Yampa#72. What is this [45] thing? Is this specific to your package or something that should work for other packages too? (and, if so, why?)
There was a problem hiding this comment.
It should be improved actually. However, this was used to ensure that the 5 exposed modules would have a 100% code coverage. But, with the changes, this PR introduced it was not the case for an instance. Just like mentioned on the linked issue.
Solves #47
Introduced two property tests for private functions quoteCmd and trim. As these functions were not exposed, change a little bit of the project structure. I will continue to add one more property test for mkGenericCommand and unGenericCommand.