Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add storage VLAN interface on all slurm nodes #391

Merged
merged 7 commits into from
Jun 3, 2024
Merged

add storage VLAN interface on all slurm nodes #391

merged 7 commits into from
Jun 3, 2024

Conversation

scrungus
Copy link
Contributor

@scrungus scrungus commented May 15, 2024 •
edited by sjpb
Loading

Additional note from @sjpb :

The .caas environment uses etc_hosts to template out /etc/hosts. By default (= .caas environment) it uses ansible_host as the IP. This is safe after this IP as stackhpc.terraform.infra/inventory_adopt uses the terraform output node.ip for this, and this is set in roles/cluster_infra/templates/outputs.tf to be network[0] on all nodes. This PR adds the storage network as the 2nd network so it will not be in /etc/hosts.

scrungus added 2 commits May 28, 2024 11:35
@scrungus
Copy link
Contributor Author

cluster_storage_network changes here https://github.com/stackhpc/azimuth/pull/236

JohnGarbutt
JohnGarbutt requested changes May 28, 2024
View reviewed changes
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, its looking good.

Mostly just a few nits around removing the comments we don't need, and renaming the network to be called "storage" rather than "storage_direct", just so we are consistent with the param.

@scrungus scrungus marked this pull request as ready for review May 28, 2024 12:43
@scrungus scrungus requested a review from a team as a code owner May 28, 2024 12:43
@scrungus
Copy link
Contributor Author

cluster_vnic_profile also removed here from the primary network as it is no longer used

JohnGarbutt
JohnGarbutt approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now. @sjpb are you happy with this too?

@sjpb
Copy link
Collaborator

sjpb commented May 31, 2024

cluster_vnic_profile also removed here from the primary network as it is no longer used

@scrungus why not?

@scrungus scrungus merged commit 4433026 into main Jun 3, 2024
1 check passed
@scrungus scrungus deleted the add-storage-network branch June 3, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb left review comments

@JohnGarbutt JohnGarbutt JohnGarbutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scrungus @sjpb @JohnGarbutt