Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds project setup and initial Prometheus and OpenSearch tests #1

Merged
merged 5 commits into from
May 17, 2024

Conversation

markgoddard
Copy link
Contributor

No description provided.

@markgoddard markgoddard self-assigned this May 15, 2024
Copy link
Contributor

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the code, but I'm also wondering what your thoughts are with regards to versioning?

We could go the standard stackhpc/release branch route, which would make integration with release train easy. I think I'd also rather pin to branches in SKC than commits, to save the effort of changing it constantly.

@markgoddard
Copy link
Contributor Author

I approve of the code, but I'm also wondering what your thoughts are with regards to versioning?

We could go the standard stackhpc/release branch route, which would make integration with release train easy. I think I'd also rather pin to branches in SKC than commits, to save the effort of changing it constantly.

It's a good question. This is really at quite an early stage, but I wanted to get something started that can evolve. I was thinking more along the lines of a single branch with tags, but perhaps we would end up needing to diverge as things change over time. I was trying to keep the tests fairly generic, and pass in various things through environment variables. Potentially we could pass in the release name and encode any logic in the test suite about which tests need to run. Would that be easier to maintain than multiple branches?

@Alex-Welsh
Copy link
Contributor

I approve of the code, but I'm also wondering what your thoughts are with regards to versioning?
We could go the standard stackhpc/release branch route, which would make integration with release train easy. I think I'd also rather pin to branches in SKC than commits, to save the effort of changing it constantly.

It's a good question. This is really at quite an early stage, but I wanted to get something started that can evolve. I was thinking more along the lines of a single branch with tags, but perhaps we would end up needing to diverge as things change over time. I was trying to keep the tests fairly generic, and pass in various things through environment variables. Potentially we could pass in the release name and encode any logic in the test suite about which tests need to run. Would that be easier to maintain than multiple branches?

Keeping the logic inside the test suite sounds good. Saves a lot of complexity vs managing multiple branches. Easy to extend as well since I assume at some point we will have environment-specific options e.g. OVS/OVN, TLS, OS

@markgoddard markgoddard merged commit 943e987 into main May 17, 2024
@markgoddard markgoddard deleted the prometheus-opensearch branch May 17, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants