Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version subcommand for frizbee #56

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

kranurag7
Copy link
Contributor

Fixes #6

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2023

CLA assistant check
All committers have signed the CLA.

@JAORMX
Copy link
Contributor

JAORMX commented Dec 22, 2023

The test failure seems unrelated

@kranurag7
Copy link
Contributor Author

$ uname -ms
Linux x86_64 
$ crane digest nginx:1.25.3
sha256:2bdc49f2f8ae8d8dc50ed00f2ee56d00385c6f8bc8a8b320d0a294d9e3b49026
$ go test
PASS
ok  	github.com/stacklok/frizbee/pkg/containers	2.738s

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pity that we need to pass in a tagged version ID by hand, but I can understand why that is.

@evankanderson evankanderson merged commit cdcae14 into stacklok:main Dec 22, 2023
6 checks passed
@kranurag7 kranurag7 deleted the kr/add-version branch December 22, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command for getting frizbee version
4 participants