Allow stripping manifest from the CR status #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBaeumer
approved these changes
Jul 1, 2021
SimonBaeumer
pushed a commit
that referenced
this pull request
May 5, 2022
vladbologa
pushed a commit
that referenced
this pull request
Aug 31, 2022
vladbologa
pushed a commit
that referenced
this pull request
Sep 1, 2022
vladbologa
pushed a commit
that referenced
this pull request
Sep 2, 2022
misberner
added a commit
that referenced
this pull request
Oct 3, 2022
ludydoo
pushed a commit
that referenced
this pull request
Jun 27, 2023
ludydoo
pushed a commit
that referenced
this pull request
Jun 27, 2023
ludydoo
pushed a commit
that referenced
this pull request
Jun 27, 2023
ludydoo
pushed a commit
that referenced
this pull request
Aug 4, 2023
porridge
pushed a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
status.deployedRelease.manifestfield contains the entire manifest, i.e., all the YAMLs rendered from Helm. This can easily cause sensitive data that should only be stored in a secret to end up in the status field.Therefore, add an option to suppress the manifest from the release status.