Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Only accept deposits if all inputs are fine #1046

Closed
1 task
djordon opened this issue Dec 5, 2024 · 0 comments · Fixed by #1045
Closed
1 task

[Feature]: Only accept deposits if all inputs are fine #1046

djordon opened this issue Dec 5, 2024 · 0 comments · Fixed by #1045
Assignees
@djordon
Labels
sbtc signer binary The sBTC Bootstrap Signer. signer blocklist client The dynamic blocklist client that runs on signer hosts.
Milestone
sBTC 0.9, mainnet...

Comments

@djordon
Copy link
Collaborator

djordon commented Dec 5, 2024

Feature - Only accept deposits if all inputs are fine

1. Description

Right now we accept a deposit if any of the inputs are fine, but we should only accept a deposit if all inputs are fine.

1.1 Context & Purpose

2. Technical Details:

This is a simple change.

2.1 Acceptance Criteria:

  • We only accept deposits if all inputs pass from the blocklist client.

3. Related Issues and Pull Requests (optional):
@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. signer blocklist client The dynamic blocklist client that runs on signer hosts. labels Dec 5, 2024
@djordon djordon added this to the sBTC Release Ready milestone Dec 5, 2024
@djordon djordon self-assigned this Dec 5, 2024
@djordon djordon added this to sBTC Dec 5, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Dec 5, 2024
@djordon djordon moved this from Needs Triage to In Review in sBTC Dec 5, 2024
@djordon djordon mentioned this issue Dec 5, 2024
Merged
1 task
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Dec 7, 2024
@djordon djordon mentioned this issue Dec 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djordon djordon

Labels
sbtc signer binary The sBTC Bootstrap Signer. signer blocklist client The dynamic blocklist client that runs on signer hosts.
Projects
sBTC
Status: Done
Milestone
sBTC 0.9, mainnet release
Development

Successfully merging a pull request may close this issue.

fix: only accept deposits if all inputs are fine stacks-network/sbtc
1 participant
@djordon