Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only accept deposits if all inputs are fine #1045

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix: only accept deposits if all inputs are fine #1045

merged 1 commit into from
Dec 7, 2024

Conversation

djordon
Copy link
Collaborator

@djordon djordon commented Dec 5, 2024 •
edited
Loading

Description

Closes #1046

This came up recently and the more natural position is to reject a deposit if any input into the transaction is invalid.

Changes

  • Reject deposits if any of the inputs cannot be accepted.

Testing Information

I do not believe we use the blocklist client in tests so they should all pass.

Checklist:

  • I have performed a self-review of my code

@djordon djordon added the signer blocklist client The dynamic blocklist client that runs on signer hosts. label Dec 5, 2024
@djordon djordon added this to the sBTC Release Ready milestone Dec 5, 2024
@djordon djordon self-assigned this Dec 5, 2024
@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Dec 5, 2024
@djordon djordon changed the title feat: only accept deposits if all inputs are fine fix: only accept deposits if all inputs are fine Dec 7, 2024
@djordon djordon merged commit c17ed52 into main Dec 7, 2024
4 checks passed
@djordon djordon deleted the reverse-can-accept-permissiveness branch December 7, 2024 07:02
@djordon djordon mentioned this pull request Dec 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteojug matteojug matteojug approved these changes

@aldur aldur aldur approved these changes

@Jiloc Jiloc Awaiting requested review from Jiloc

@AshtonStephens AshtonStephens Awaiting requested review from AshtonStephens

@cylewitruk cylewitruk Awaiting requested review from cylewitruk

Assignees

@djordon djordon

Labels
sbtc signer binary The sBTC Bootstrap Signer. signer blocklist client The dynamic blocklist client that runs on signer hosts.
Projects
sBTC
Status: Done
Milestone
sBTC 0.9, mainnet release
Development

Successfully merging this pull request may close these issues.

[Feature]: Only accept deposits if all inputs are fine
3 participants
@djordon @aldur @matteojug