Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make stacks transaction fee estimation more robust #366

Closed
2 tasks
djordon opened this issue Jul 30, 2024 · 1 comment · Fixed by #368
Closed
2 tasks

[Feature]: Make stacks transaction fee estimation more robust #366

djordon opened this issue Jul 30, 2024 · 1 comment · Fixed by #368
Assignees
Labels
sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Contributor

djordon commented Jul 30, 2024

Feature - Make stacks transaction fee estimation more robust

1. Description

We only have one source for expected fees for stacks transactions, which could potentially return weird estimates for the expected fees. This ticket is to have some safeguards in place for fee estimation.

Also, we need to figure out whether we should use the high or medium priority transaction fee estimates for sBTC related stacks transactions.

1.1 Context & Purpose

2. Technical Details:

2.1 Acceptance Criteria:

  • Make the stacks transaction fee estimation code more robust.
  • Maybe change to using the medium priority stacks transaction fee estimate.

3. Related Issues and Pull Requests (optional):

This came up in this discussion #361 (comment), which addressed #233.

@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Jul 30, 2024
@djordon djordon added this to sBTC Jul 30, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jul 30, 2024
@djordon
Copy link
Contributor Author

djordon commented Jul 30, 2024

Hmm, we probably want high priority for rotate-keys contract calls and medium (or maybe even low) priority for other transactions, like withdrawal-accept.

@djordon djordon moved this from Needs Triage to Todo in sBTC Jul 30, 2024
@djordon djordon moved this from Todo to In Progress in sBTC Jul 30, 2024
@djordon djordon self-assigned this Jul 30, 2024
@djordon djordon moved this from In Progress to In Review in sBTC Jul 30, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant