Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: robust stacks transaction fee estimation #368

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

djordon
Copy link
Collaborator

@djordon djordon commented Jul 30, 2024

Description

Closes #366. And is a follow-up to #361.

Changes

  • Cap the maximum fee that signers will pay for a transaction to 10 STX.
  • Allow the fee priority to be selected by the caller of the estimation function.

Testing information

The existing tests we updated to support the new functionality.

@djordon djordon requested review from xoloki and AshtonStephens July 30, 2024 17:31
@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Jul 30, 2024
Base automatically changed from 233-support-estimating-contract-calls-fees to main July 30, 2024 20:32
djordon added 2 commits July 30, 2024 16:35
…as a parameter and be robust to wonky fee prices by capping the tx fee.
@djordon djordon force-pushed the 366-robust-stacks-transaction-fee-estimation branch from 62a8cce to 0aba7ba Compare July 30, 2024 20:36
@djordon djordon merged commit 2b9b67b into main Jul 30, 2024
4 checks passed
@djordon djordon deleted the 366-robust-stacks-transaction-fee-estimation branch July 30, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Make stacks transaction fee estimation more robust
2 participants