Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: Clarity Bugs #971

Closed
4 tasks
setzeus opened this issue Nov 27, 2024 · 0 comments · Fixed by #972
Closed
4 tasks

[Chore]: Clarity Bugs #971

setzeus opened this issue Nov 27, 2024 · 0 comments · Fixed by #972

Comments

@setzeus
Copy link
Collaborator

setzeus commented Nov 27, 2024

Chore - Clarity Bugs

1. Description

@friedger was kind enough to point out two existing bugs in the Clarity contracts:

  • An extra response wrapper in the 'complete-deposit-wrapper' function
  • A recalculated value that's already saved as a variable

2. Why It's Necessary

The first issue could (possibly?) lead to an exploit since it's possible the contract call fails since the sbtc-registry contracts updates with 'map-insert'.

The second issue is strictly optimization.

3. Execution Checklist

  • Remove the (ok ...) wrapper from the 'complete-deposit' contract-call
  • Reuse 'version-int' variable
@setzeus setzeus added the chore label Nov 27, 2024
@setzeus setzeus mentioned this issue Nov 27, 2024
4 tasks
@djordon djordon added this to sBTC Nov 27, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Nov 27, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in sBTC Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants