Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Clarity Issues #972

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Minor Clarity Issues #972

merged 1 commit into from
Nov 28, 2024

Conversation

setzeus
Copy link
Collaborator

@setzeus setzeus commented Nov 27, 2024

Description

This small PR addresses two bugs for the Clarity contracts recently opened under a single issue.

Closes: #971

Changes

Both changes mentioned in linked issue are implemented. Removed the unnecessary (ok ...) wrapper & reused the 'version-int' variable.

Testing Information

No new tests were added but all unit tests still intact.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@setzeus setzeus requested review from hstove and djordon November 27, 2024 14:58
Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

But isn't there something to test here? Before the failure mode would occur if the contract caller wasn't the "protocol caller". And I think sBTC would still be being minted in that case, since that happens before the protocol caller check. I might be misreading or misunderstanding, but if not we should add an explicit test that contract calls from non-protocol callers would not lead to sBTC being minted.

@djordon
Copy link
Collaborator

djordon commented Nov 27, 2024

I misread the issue, we do that check before hand so there is nothing to really test.

Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Yeah looks good!

@setzeus setzeus merged commit 2a3b9eb into main Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore]: Clarity Bugs
2 participants