Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: Return using of blocklist command line arguments where necessary #981

Open
2 tasks
MCJOHN974 opened this issue Nov 28, 2024 · 0 comments
Open
2 tasks
Assignees
Labels

Comments

@MCJOHN974
Copy link
Collaborator

Chore - Return using of blocklist command line arguments where necessary

1. Description

In #964 we removed usage of blocklist client command line arguments, since they was ignored. Now they are supported, and this issue aims to return them where necessary, and test that it don't brake anything

2. Why It's Necessary

Once we discovered that command line arguments was ignored, and now they deleted, this mean that at some places we probably fallback to default config while developer intention was to use a custom one. We should investigate it.

3. Execution Checklist

  • restore usage of command line arguments in places where it necessary and test it
  • write small explanation in PR discussion why we don't want to restore usage of command line arguments in other places
@MCJOHN974 MCJOHN974 self-assigned this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant