Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignored command line arguments #964

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

MCJOHN974
Copy link
Collaborator

@MCJOHN974 MCJOHN974 commented Nov 26, 2024

Description

As we found in #962 blocklist client just ignored command line arguments passed to it. Thus removing this arguments to not mislead anybody who will read the code. Also removing copying of blocklist config files from local machine to docker image. Maybe I removed a bit more than necessary, if true, will restore this during review

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MCJOHN974 MCJOHN974 marked this pull request as ready for review November 26, 2024 14:11
@MCJOHN974
Copy link
Collaborator Author

I didn't run anything more than CI manually, but it is kind of job of CI to block me, right? =)

@MCJOHN974
Copy link
Collaborator Author

Follow up from our call:

  • Suggestion: don't remove some flags since they are supported now
  • My concern about it: I think restoring usage of this flag is in scope of "pass correct config to docker" not in scope of "make arguments really working", and need some more testing and context about "where this configs came from? what they should be?"

Thus I suggest to create separate issue for it

@MCJOHN974 MCJOHN974 merged commit 097e7fb into main Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants