fix: always use 32-bit math for determining coordinator index #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteojug
reviewed
Dec 5, 2024
…tate-divergence-between-signers
…tate-divergence-between-signers
djordon
approved these changes
Dec 5, 2024
matteojug
approved these changes
Dec 5, 2024
cylewitruk
deleted the
985-feature-partial-use-of-usize-can-cause-state-divergence-between-signers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #985
Changes
Changes the
coordinator_public_key()function of the coordinator to always use 32-bit math instead ofusize(which can either be 32- or 64-bit) when determining the current coordinator's public key from bitcoin block hash.Testing Information
All existing tests pass.
Checklist: