Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove ApiKey need from Emily Get Limit requests #1033

Merged
merged 5 commits into from
Dec 10, 2024
Merged

feat: Remove ApiKey need from Emily Get Limit requests #1033

merged 5 commits into from
Dec 10, 2024

Conversation

AshtonStephens
Copy link
Collaborator

@AshtonStephens AshtonStephens commented Dec 4, 2024 •
edited
Loading

Description

Closes: #N/A

Changes

Removes the need for API keys from the emily get limits endpoint

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AshtonStephens AshtonStephens self-assigned this Dec 4, 2024
@AshtonStephens AshtonStephens marked this pull request as ready for review December 9, 2024 12:52
@AshtonStephens AshtonStephens requested a review from Jiloc December 9, 2024 12:52
@aldur aldur added this to the sBTC 0.9, mainnet release milestone Dec 9, 2024
@djordon djordon added the emily API that communicates with Signers to trigger sBTC operations. label Dec 10, 2024
@AshtonStephens AshtonStephens requested a review from Jiloc December 10, 2024 14:34
Jiloc
Jiloc approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AshtonStephens AshtonStephens merged commit 6f68a5b into main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiloc Jiloc Jiloc approved these changes

Assignees

@AshtonStephens AshtonStephens

Labels
emily API that communicates with Signers to trigger sBTC operations.
Projects
sBTC
Status: Done
Milestone
sBTC 0.9, mainnet release
Development

Successfully merging this pull request may close these issues.
4 participants
@AshtonStephens @Jiloc @aldur @djordon