fix: remove sweep transaction message #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_swept_deposit_requests
get_pending_accepted_deposit_requests query
or write to the sweep tables. Remove now unused code
instead of the sweep tables
djordon
added
bug
cylewitruk
reviewed
Dec 7, 2024
|
This is protocol-breaking, right? Since non-upgraded signers will still try use this information but won't receive it from upgraded coordinators? The upgraded signers should just log an error i guess when receiving the (now removed) messages from older coordinators? |
djordon
added
breaking-local
matteojug
approved these changes
Dec 9, 2024
don't need to. Instead we need to store the stacks genesis block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1057
Changes
SweepTransactionInfomessage.Sweep*types that fed intoSweepTransactionInfomessages.sweep_*tables.sweep_*tables withbitcoin_tx_*in the queries. This changes the queries inget_swept_deposit_requestsandget_pending_accepted_deposit_requests.sweep_*tables.Testing Information
This is a (large) refactor. The signers no longer broadcast a message and rely on other tables for sweep information.
Checklist: