Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement signer metrics exporter #1084

Merged
merged 13 commits into from
Dec 10, 2024
Merged

feat: implement signer metrics exporter #1084

merged 13 commits into from
Dec 10, 2024

Conversation

djordon
Copy link
Collaborator

@djordon djordon commented Dec 10, 2024

Description

Closes #1049.

This PR adds some metrics around the following:

  • New bitcoin block notification from bitcoin-core.
  • New stacks block webhook from stacks-core.
  • Stacks and bitcoin validation, with timings.
  • Signing round duration with a counter.
  • Transaction submission.

Changes

  • Instrument the application with some metrics.
  • Add a configurable parameter to enable a Prometheus scrape exporter.

Testing Information

I will add local prometheus setup in a separate PR.

Checklist:

  • I have performed a self-review of my code

@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. Observability labels Dec 10, 2024
@djordon djordon added this to the sBTC 0.9, mainnet release milestone Dec 10, 2024
@djordon djordon self-assigned this Dec 10, 2024
cylewitruk
cylewitruk reviewed Dec 10, 2024
View reviewed changes
signer/src/api/new_block.rs Outdated Show resolved Hide resolved
signer/src/lib.rs Show resolved Hide resolved
matteojug
matteojug approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@matteojug matteojug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

signer/src/block_observer.rs Outdated Show resolved Hide resolved
signer/src/transaction_coordinator.rs Outdated Show resolved Hide resolved
signer/src/transaction_coordinator.rs Outdated Show resolved Hide resolved
signer/src/transaction_coordinator.rs Outdated Show resolved Hide resolved
signer/src/transaction_signer.rs Outdated Show resolved Hide resolved
@djordon djordon merged commit 5ce32bf into main Dec 10, 2024
4 checks passed
@djordon djordon deleted the 1049-implement-signer-metrics-exporter branch December 10, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cylewitruk cylewitruk cylewitruk left review comments

@matteojug matteojug matteojug approved these changes

@Jiloc Jiloc Awaiting requested review from Jiloc

Assignees

@djordon djordon

Labels
Observability sbtc signer binary The sBTC Bootstrap Signer.
Projects
sBTC
Status: Done
Milestone
sBTC 0.9, mainnet release
Development

Successfully merging this pull request may close these issues.

[Feature]: Implement signer metrics & exporter
3 participants
@djordon @matteojug @cylewitruk