Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sbtc] Remove unused constants in sBTC token contract #1092

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Conversation

friedger
Copy link
Contributor

@friedger friedger commented Dec 10, 2024

Description

Remove unused constants in sBTC token contract

Changes

Removes two constants from contract that were not used.
Removes check-checker and related comments to reduce size of contract

Testing Information

Unit test adapted.
More unit tests added.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@friedger friedger added the clarity The clarity smart contracts. label Dec 10, 2024
Copy link
Collaborator

@setzeus setzeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR consists of removing unused constant, unused comments & minimal formatting changes (such as error codes in 'sbtc-token').

Only one question re: failed costs at 400 but looks good to me otherwise (assuming 'git is dirty' issue is fixed cc @djordon)

@djordon
Copy link
Collaborator

djordon commented Dec 11, 2024

@friedger have you tried running make build locally and pushing the changes up? Sometimes that work, but sometimes not.

@friedger
Copy link
Contributor Author

I don't know why the check fails due to dirty git. Where get files changed?

@djordon
Copy link
Collaborator

djordon commented Dec 11, 2024

We run make build in CI, which generates some files. Here there are some documentation files that get generated based on the clarity source, so if the source changes the documentation will automatically get updated.

@djordon djordon merged commit f741ad5 into main Dec 11, 2024
4 checks passed
@djordon djordon deleted the chore/sbtc-tests branch December 11, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarity The clarity smart contracts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants