Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clarity] Remove unused consts #1110

Merged
merged 5 commits into from
Dec 12, 2024
Merged

[clarity] Remove unused consts #1110

merged 5 commits into from
Dec 12, 2024

Conversation

friedger
Copy link
Contributor

@friedger friedger commented Dec 12, 2024 •
edited
Loading

Description

This PR

  • removes unused constants and a duplicate function.
  • removes test code from registry contract
  • replaces space with tab

Changes

Testing Information

Test coverage has been increased to 95+%

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@friedger friedger added the clarity The clarity smart contracts. label Dec 12, 2024
@friedger
Copy link
Contributor Author

Not sure how to fix the lint error

setzeus
setzeus requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@setzeus setzeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General cleanup & testing optimization LGTM, just adding one requirement re: the discussion we had on the 'protocol-transfer' function.

setzeus
setzeus approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@setzeus setzeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing that function, assuming CI passes LGTM!

contracts/contracts/sbtc-token.clar Outdated Show resolved Hide resolved
@setzeus setzeus merged commit 8fe9a46 into main Dec 12, 2024
4 checks passed
@djordon djordon mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setzeus setzeus setzeus approved these changes

Assignees
No one assigned
Labels
clarity The clarity smart contracts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friedger @setzeus