fix: run DKG only once #1115
Merged
fix: run DKG only once #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
searching for DKG shares
each sighash
djordon
added
sbtc signer binary
|
Oh I figured out how to test that we sign things correctly, even when locking deposits and signer UTXOs with different keys. It isn't so bad, will add tomorrow. |
cylewitruk
reviewed
Dec 13, 2024
| @@ -1467,10 +1475,10 @@ impl super::DbRead for PgStore { | |||
| , signer_set_public_keys | |||
| , signature_share_threshold | |||
| FROM sbtc_signer.dkg_shares | |||
| WHERE aggregate_key = $1; | |||
| WHERE substring(aggregate_key FROM 2) = $1; | |||
There was a problem hiding this comment.
Just a nit -- I think I would have preferred that we stored this in an extra column instead of messing around with it at query-time. I think we do something similar and even more convoluted somewhere else..
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1114
Changes
Testing Information
No tests yet, hence the draft status.
Checklist: