Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update block hash along with reorg. #1120

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

AshtonStephens
Copy link
Collaborator

@AshtonStephens AshtonStephens commented Dec 13, 2024

Description

Closes: #N/A

There's an issue with the reorg logic where the reorg updates the height, but it doesn't update the hash or fulfillment.

Changes

Updates the reorganizing behavior to fix the bug.

Testing Information

Added unit tests for the reorganizing.

Note: This is currently failing due to the intermittent swatinem caching error, but the tests are passing: link

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@AshtonStephens AshtonStephens added the emily API that communicates with Signers to trigger sBTC operations. label Dec 13, 2024
@AshtonStephens AshtonStephens requested a review from Jiloc December 13, 2024 12:55
@AshtonStephens AshtonStephens self-assigned this Dec 13, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@AshtonStephens AshtonStephens marked this pull request as ready for review December 13, 2024 13:00
Copy link
Collaborator

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Also, good finding 🚀

@AshtonStephens AshtonStephens merged commit 9dd76d9 into main Dec 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emily API that communicates with Signers to trigger sBTC operations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants