Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean up databases in integration tests #1123

Merged
merged 2 commits into from
Dec 15, 2024
Merged

ci: clean up databases in integration tests #1123

merged 2 commits into from
Dec 15, 2024

Conversation

djordon
Copy link
Collaborator

@djordon djordon commented Dec 13, 2024

Description

We've been running out of disk space in CI. These changes should fix that... hopefully.

Maybe one day we'll create a procedural macro, like the one that sqlx has that does this cleanup for you.

Changes

  • Delete databases at the end of integration tests.

Testing Information

If tests are green then we're good.

Checklist:

  • I have performed a self-review of my code

@djordon
Copy link
Collaborator Author

djordon commented Dec 14, 2024

This didn't solve our CI issues, deleting the cache did, but this doesn't hurt.

Copy link
Collaborator

@matteojug matteojug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may be missing one in load_latest_deposit_requests_persists_requests_from_past as well

@djordon djordon merged commit 6ccc1f4 into main Dec 15, 2024
4 checks passed
@djordon djordon deleted the fix-test-cleanup branch December 15, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants