-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[featue] move events module to sbtc crate #1144
Conversation
Yeah, I also don't like creating 3rd PR for same issue but I guess this commit considers all previous notes and is good enough now |
2dee9ed
to
c991972
Compare
@djordon I believe few commits above fixes all review notes except "We should use local types for key rotation events ". For this note I'm wondering if we want to have any difference between local and sbtc key rotation events. If yes than how this differences should look like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that we'll also want to move the signer/src/stacks/webhooks.rs
file over to the sbtc crate as well. You'll should feature gate the webhooks module though and if you like I can help with that.
Maybe this pr is in progress for too long and refactoring webhooks and events are different enough tasks to make them in separate pr |
@djordon I think commits above fix new issues and we can go back to question "how local upd: I think local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ✅
Description
Closes #1016
Changes
Testing Information
Checklist: