Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add handler for new attachments #1185

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

matteojug
Copy link
Collaborator

Description

The sBTC signers stalled their Stacks nodes in prod when the nodes emitted "attachment" events (which is a known bug on the node-side), and the sBTC signers couldn't handle it.

Changes

This adds a dummy endpoint responding with 200 OK.

Testing Information

Add simple test, and tested that everything else still works via devenv demo script.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@matteojug matteojug merged commit 83b316c into main Jan 7, 2025
4 checks passed
@matteojug matteojug deleted the fix/new-attachments-api branch January 7, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants